refactor(language-service): stricter context isolation for Service interface#100
Merged
johnsoncodehk merged 2 commits intomasterfrom Dec 4, 2023
Merged
refactor(language-service): stricter context isolation for Service interface#100johnsoncodehk merged 2 commits intomasterfrom
Service interface#100johnsoncodehk merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Serviceinterface has been renamed toServicePluginServicePluginFactory. Therefore the language server no longer needs to create fake service plugin instances in order to collect trigger characters.SharedModules, and the modules that the service depends on should be exposed through the parameters of the create function