add viewport-fit to list of valid viewport directives#111
Merged
rviscomi merged 7 commits intorviscomi:mainfrom May 25, 2024
Merged
add viewport-fit to list of valid viewport directives#111rviscomi merged 7 commits intorviscomi:mainfrom
rviscomi merged 7 commits intorviscomi:mainfrom
Conversation
Contributor
Author
|
Also included validation for the allowed values. I included the allowed values in the error message, which diverts from the other error messages but is more helpful. |
rviscomi
reviewed
May 20, 2024
Owner
rviscomi
left a comment
rviscomi
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Just one request, then could you also rerun the build script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has three things:
fixes #110