refactor(language-core): make embeddedCodes optional in VirtualCode#137
Merged
johnsoncodehk merged 2 commits intomasterfrom Feb 20, 2024
Merged
refactor(language-core): make embeddedCodes optional in VirtualCode#137johnsoncodehk merged 2 commits intomasterfrom
johnsoncodehk merged 2 commits intomasterfrom
Conversation
In many cases `embeddedCodes` is always empty. It might as well be optional.
Contributor
|
Breaking change (maybe someone relies on it being an empty array and uses |
Member
Author
|
For Volar |
Member
|
I agree that embeddedCodes should be optional, the purpose of it being required in the past was to guide developers to implement embedded code (due to lack of documentation). But I'm sure we'll make progress on the documentation soon. Since this is a breaking change, this will be released in 2.1 (Volar does not follow semantic versioning) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases
embeddedCodesis always empty. It might as well be optional.