feat(language-service): more reliable embedded code formatting#138
Merged
johnsoncodehk merged 1 commit intomasterfrom Feb 20, 2024
Merged
feat(language-service): more reliable embedded code formatting#138johnsoncodehk merged 1 commit intomasterfrom
johnsoncodehk merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded code indentation is no longer handled by
@volar/language-service, but instead calculated and passed asinitialIndentLevel, which is then reliably handled by ServicePlugin for additional indentation in specific languages.The
provideDocumentFormattingEditsandprovideOnTypeFormattingEditsAPIs now accept theEmbeddedCodeFormattingOptionsparameter, which includesinitialIndentLevel.Formatting ranges are now correctly mapped to embedded code formatting ranges.
Removed the no longer needed
ServicePlugin.provideFormattingIndentSensitiveLinesAPI.No longer relies on the conventional
volar.format.initialIndenteditor setting.Added
ServicePlugin.resolveEmbeddedCodeFormattingOptionsAPI, allowing downstream tools to modify theinitialIndentLevelpassed to ServicePlugin based on custom settings (replacingvolar.format.initialIndent).Here's an example of its usage in Vue:
With these changes, all formatting tests in microsoft/vscode#171547 have passed.