refactor(language-server): isolate TS dependency for Server and ServerProjectProviderFactory#140
Merged
johnsoncodehk merged 2 commits intomasterfrom Feb 23, 2024
Merged
Conversation
…rverProjectProviderFactory`
Server and Se rProjectProviderFactoryServer and ServerProjectProviderFactory
remcohaszing
added a commit
that referenced
this pull request
Feb 26, 2024
This allows people to load TypeScript as suggested in #140. Since `initializationOptions` is of type `any` there, it doesn’t really matter. But the `InitializationOptions` interface is used by the test utils and prohibits the user from passing additional properties. Also it’s nice if all Volar based language servers that do allow the client to pass the TypeScript SDK, do so in a consistent manner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following options have been removed from the Server InitializationOptions interface:
typescript#tsdktypescript#tsdkUrlignoreTriggerCharacterscreateSimpleProjectProviderhas been renamed tocreateSimpleProjectProviderFactoryand needs to be invoked with no arguments.createTypeScriptProjectProviderhas been renamed tocreateTypeScriptProjectProviderFactoryand needs to be invoked with a TS module as an argument.The core code of
@volar/language-serverno longer loads TSDK withserver.initialize(), so you now need to manually load TSDK. Here is an example from Vue Language Tools:There are also some internal code adjustments that people shouldn't need to be concerned about.