feat(language-service): add provide generic to ServicePlugin type#143
Merged
johnsoncodehk merged 1 commit intomasterfrom Feb 28, 2024
Merged
feat(language-service): add provide generic to ServicePlugin type#143johnsoncodehk merged 1 commit intomasterfrom
johnsoncodehk merged 1 commit intomasterfrom
Conversation
This allows a service plugin instance provide value to be inferred without the need for an explicit type annotation on the create function.
Member
|
Thanks! btw I recommend always type-annotating the create method, otherwise unknown options cannot be caught: const servicePlugin: ServicePlugin = {
create() {
return {
aTypoOption: 123, // Expected report type error but didn't
};
},
};
const servicePlugin: ServicePlugin = {
create(): ServicePluginInstance {
return {
aTypoOption: 123, // Now report as expected
};
},
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a service plugin instance provide value to be inferred without the need for an explicit type annotation on the
createmethod.