Skip to content

fix(monaco): correct package name resolve#149

Merged
johnsoncodehk merged 2 commits intovolarjs:masterfrom
sxzz:fix/node-modules-prefix
Mar 5, 2024
Merged

fix(monaco): correct package name resolve#149
johnsoncodehk merged 2 commits intovolarjs:masterfrom
sxzz:fix/node-modules-prefix

Conversation

@sxzz
Copy link
Contributor

@sxzz sxzz commented Mar 2, 2024

  • Should remove /node_modules/ prefix from fileName, not uri
  • Correct package name

@sxzz sxzz marked this pull request as draft March 2, 2024 08:33
@sxzz
Copy link
Contributor Author

sxzz commented Mar 2, 2024

There is more than one bug, hold on

@sxzz sxzz changed the title fix(monaco): remove node_module prefix fix(monaco): ata Mar 2, 2024
@sxzz sxzz changed the title fix(monaco): ata fix(monaco): get package name Mar 2, 2024
@sxzz sxzz marked this pull request as ready for review March 2, 2024 08:53
@johnsoncodehk johnsoncodehk changed the title fix(monaco): get package name fix(monaco): correct package name resolve Mar 5, 2024
@johnsoncodehk johnsoncodehk merged commit 674a7a0 into volarjs:master Mar 5, 2024
@sxzz sxzz deleted the fix/node-modules-prefix branch March 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants