fix: vue-tsc does not show ts errors in the terminal with --incremental#158
Merged
johnsoncodehk merged 4 commits intovolarjs:masterfrom Apr 4, 2024
Merged
Conversation
Member
|
Thanks for the investigation, I tried proxy |
Contributor
Author
Oh, this is a really great fix that is more compatible with the current I just tested the fix and it's working fine and I haven't found any problems yet! I once tried to proxy |
Member
|
Thanks for confirming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to fix the issue I raised:
TypeScript errors are not displayed in terminal with
--incremental(vue-tsc@2) vuejs/language-tools#4194In the process of locating the problem, I found that when
tsc --incrementalis run repeatedly, the TS error message is converted bytsc.js'sconvertToDiagnosticRelatedInformationmethod, which does not correctly get the text content corresponding to the error. So, I'm going to proxy this function to getdiagnostic.file.textcorrectly.I don't think my solution is very elegant, and I'm worried about introducing new issues, but at least I hope to provide some clues. Since I'm not familiar with volar at the moment, I'm expecting a simpler fix as well.