Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 🐛 BUG: Neovim broken lsp on dynamic routes withastro/language-tools#802 (comment), we found that stringified URIs are not reliable document IDs. We should pass URI instances as document IDs whenever possible. This also allows for more reuse of URI instances and reduces URI parsing.
URIConverter (URI <-> fileName) is specific to TypeScript and should not be coupled with language-server/language-service.
The scriptId of
LanguagePlugincould be in either fileName or stringified URI format in the past, which caused confusion. Now, we can explicitly declare this through generic parameters, whereLanguagePluginshould specify the accepted script ID type. For TS plugins, it should beLanguagePlugin<string>, and for LSP, it should beLanguagePlugin<URI>. Alternatively, a more common approach is to accept both types simultaneously,LanguagePlugin<URI | string>.