feat(language-core): reimplement multi-source mapping#194
Merged
johnsoncodehk merged 5 commits intomasterfrom Jun 5, 2024
Merged
feat(language-core): reimplement multi-source mapping#194johnsoncodehk merged 5 commits intomasterfrom
johnsoncodehk merged 5 commits intomasterfrom
Conversation
This reverts commit c4b297b.
johnsoncodehk
referenced
this pull request
Jun 4, 2024
johnsoncodehk
commented
Jun 4, 2024
| } | ||
|
|
||
| export interface CodegenContext<T> { | ||
| getAssociatedScript(scriptId: T): SourceScript<T> | undefined; |
Member
Author
There was a problem hiding this comment.
In fact I'm not sure if "associated" is a better term than "related".
Contributor
|
@johnsoncodehk - thanks for taking a look at this so quickly! I am now trying to rebase my changes on top of these changes. |
Contributor
|
@johnsoncodehk - I've finally managed to rebase the changes. It took more, because I as off most of yesterday. The PR is here: #197 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c4b297b removed multi-source support, but to support Angular use cases, this PR re-implements it.
Changes
getAssociatedScriptneeds to be called to explicitly register dependencies on additional sources.associatedScriptMappingsinstead of using theMapping#sourcefield.Mapping#sourcefield has beed removed.Example: