fix(vscode): show error on missing TypeScript lib#195
Merged
johnsoncodehk merged 3 commits intovolarjs:masterfrom Jun 5, 2024
Merged
fix(vscode): show error on missing TypeScript lib#195johnsoncodehk merged 3 commits intovolarjs:masterfrom
johnsoncodehk merged 3 commits intovolarjs:masterfrom
Conversation
Member
|
Look great! Thanks for following up! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
Moves the code away from the assumption that there's always a valid TypeScript distribution available under the
${appRoot}/extensions/node_modules/typescript/libpath. While I add this change specifically for Theia, there are other (improbable) cases in which the VS Code builtin TypeScript distribution might be malformed or simply unavailable.I believe this change is breaking as
getTsdkis exported from the main index and can now also returnundefinedin addition to the original object type.Note that I'm not too familiar with the project and haven't found any instructions on testing the changes. If something doesn't work as expected, please let me know how I can test my changes before I request another review :)