perf(language-server): improve snapshot reusability#196
Merged
johnsoncodehk merged 2 commits intomasterfrom Jun 5, 2024
Merged
perf(language-server): improve snapshot reusability#196johnsoncodehk merged 2 commits intomasterfrom
johnsoncodehk merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time the file is reopened, because the SnapshotDocument instance is brand new, even if the file content hasn't changed, createVirtualCode will be rerun due to the new snapshot instance. This is resolved by using WeakRef to cache the SnapshotDocument.
When the file watcher is not enabled (LanguageServer#watchFiles not called), even if the file has been explicitly saved, the FS API always returns the cached result from the first request. This issue is mitigated by updating the cache in onDidSave.
For TS projects, the snapshot of the document during synchronization is different from the snapshot created from readFile, which causes createVirtualCode to be rerun when closing/opening the file due to switching between the document snapshot and the FS snapshot. This issue is resolved by overriding the FS snapshot cache in onDidOpen and onDidSave.