fix(language-core): should re-export SourceMap#210
Merged
johnsoncodehk merged 1 commit intovolarjs:masterfrom Jun 22, 2024
Merged
fix(language-core): should re-export SourceMap#210johnsoncodehk merged 1 commit intovolarjs:masterfrom
SourceMap#210johnsoncodehk merged 1 commit intovolarjs:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix slidevjs/slidev#1695.
#207 removed the re-exporting of
SourceMap(https://github.com/volarjs/volar.js/pull/207/files#diff-9b91681a6cad2a7185ae1fa36e153880167c7081a2a664a52c279e3c7f89a52eL1), which should be a breaking change. However, because #207 has been published in a patch version, users installing the downstream packages liketwoslash-vueandslidevwill install the new version without being notified. This caused errors, which can only be fixed by overriding the dependencies manually.This PR re-adds the re-exporting of
SourceMap. I don't know whether it's good to re-export it, but I think it should be re-added until the next major (or at least minor) version.