fix(typescript): content-sensitive features are only allowed to return results in contiguous mapped ranges#243
Merged
johnsoncodehk merged 2 commits intomasterfrom Oct 26, 2024
Merged
Conversation
…in contiguous mapped ranges
johnsoncodehk
changed the title
@volar/jsdelivr
@volar/eslint
@volar/kit
@volar/language-core
@volar/language-server
@volar/language-service
@volar/monaco
@volar/source-map
@volar/test-utils
@volar/typescript
@volar/vscode
commit: |
johnsoncodehk
added a commit
that referenced
this pull request
Oct 26, 2024
…n results in contiguous mapped ranges (#243)
Contributor
|
@johnsoncodehk - thanks for heads up! I already use continuous ranges everywhere, so nothing is affected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vuejs/language-tools#4811, closes vuejs/language-tools#4906
In the past we mapped results in discrete mapping regions for all TS features, however for content-sensitive features (such as autocomplete/formatting), results should only be returned in continuous mapping regions.
Affected features:
cc @piotrtomiak, @KazariEX