fix(typescript): fix issue with transpiled TypeScript files not being registered with a project at all#250
Merged
johnsoncodehk merged 4 commits intovolarjs:masterfrom Dec 13, 2024
Conversation
… registered with a project at all
@volar/eslint
@volar/language-core
@volar/kit
@volar/language-server
@volar/language-service
@volar/monaco
@volar/source-map
@volar/jsdelivr
@volar/test-utils
@volar/typescript
@volar/vscode
commit: |
Member
|
Thanks! This is a regression introduced in #226. I made some adjustments to this PR to make sure the fix happens in the right place, we may need to adjust the API design to better accommodate this TS behavior. |
Contributor
Author
|
@johnsoncodehk Thanks a lot for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular plugin is transpiling the TS files. Within
getScriptSnapshotthere is a code which associated scrip info with a project. Without this call, scripts are orphaned and wrong config is used during highlighting. Not sure if this fix should apply to all types of files though