fix(typescript): resolve the shim used for tsc in Typescript v5.7 and up#252
Merged
johnsoncodehk merged 6 commits intovolarjs:masterfrom Dec 13, 2024
Merged
fix(typescript): resolve the shim used for tsc in Typescript v5.7 and up#252johnsoncodehk merged 6 commits intovolarjs:masterfrom
johnsoncodehk merged 6 commits intovolarjs:masterfrom
Conversation
This was referenced Dec 6, 2024
@volar/eslint
@volar/jsdelivr
@volar/kit
@volar/language-core
@volar/language-server
@volar/language-service
@volar/monaco
@volar/source-map
@volar/test-utils
@volar/typescript
@volar/vscode
commit: |
Member
|
I made a few modifications to your approach. Thanks for look into this! |
johnsoncodehk
added a commit
to vuejs/language-tools
that referenced
this pull request
Dec 23, 2024
TS 5.7 issue is fixed by upstream: volarjs/volar.js#252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #251.
I made the checks for detecting whether or not
tscPathis pointed at a shim as resistant to change as I could think to make them (without trying to parse an AST). Because we rely on Typescript's source code, there's always a chance that a future update could break things, but this should be fairly resilient.I tested this on a local repository and have verified that it fixes the issue when using Typescript v5.7.2. It also maintains backwards compatibility for older Typescript versions that don't use a shim for tsc.