perf(language-core): only synchronize the source file currently needed#89
Merged
johnsoncodehk merged 1 commit intomasterfrom Nov 19, 2023
Merged
perf(language-core): only synchronize the source file currently needed#89johnsoncodehk merged 1 commit intomasterfrom
johnsoncodehk merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileProvidercan no longer access all virtual files, as this requires implementing a synchronized function that updates all project source files. Instead, the upper layer should loop through its list of source files and request virtual files from theFileProviderone by one.The advantage of this is that the synchronization function drops from O(n) to O(1).