Warn about viewport shrink-to-fit directive (#108)

rviscomi · web-flow · commit c8f04e29f99a · 2024-04-23T08:32:53.000-04:00
diff --git a/crx/capo.js b/crx/capo.js
diff --git a/crx/manifest.json b/crx/manifest.json
@@ -2,7 +2,7 @@
   "manifest_version": 3,
   "name": "Capo: get your ﹤𝚑𝚎𝚊𝚍﹥ in order",
   "description": "Visualize the optimal ordering of ﹤𝚑𝚎𝚊𝚍﹥ elements on any web page",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "permissions": [
     "scripting",
     "activeTab",
diff --git a/docs/src/lib/capo.js b/docs/src/lib/capo.js
@@ -890,6 +890,7 @@ function $c322f9a5057eaf5c$var$validateMetaViewport(element) {
         ];
         if (!validValues.includes(interactiveWidget)) warnings.push(`Unsupported value "${interactiveWidget}" found.`);
     }
+    if ("shrink-to-fit" in directives) warnings.push("The shrink-to-fit directive has been obsolete since iOS 9.2.\n  See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html");
     const validDirectives = new Set([
         "width",
         "height",
@@ -900,7 +901,8 @@ function $c322f9a5057eaf5c$var$validateMetaViewport(element) {
         "interactive-widget"
     ]);
     Object.keys(directives).filter((directive)=>{
-        return !validDirectives.has(directive);
+        // shrink-to-fit is not valid, but we have a separate warning for it.
+        return !validDirectives.has(directive) && directive != "shrink-to-fit";
     }).forEach((directive)=>{
         warnings.push(`Invalid viewport directive "${directive}".`);
     });
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rviscomi/capo.js",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "description": "Get your ﹤𝚑𝚎𝚊𝚍﹥ in order",
   "author": "Rick Viscomi",
   "license": "Apache-2.0",
diff --git a/snippet/capo.js b/snippet/capo.js
@@ -891,6 +891,7 @@ function $580f7ed6bc170ae8$var$validateMetaViewport(element) {
         ];
         if (!validValues.includes(interactiveWidget)) warnings.push(`Unsupported value "${interactiveWidget}" found.`);
     }
+    if ("shrink-to-fit" in directives) warnings.push("The shrink-to-fit directive has been obsolete since iOS 9.2.\n  See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html");
     const validDirectives = new Set([
         "width",
         "height",
@@ -901,7 +902,8 @@ function $580f7ed6bc170ae8$var$validateMetaViewport(element) {
         "interactive-widget"
     ]);
     Object.keys(directives).filter((directive)=>{
-        return !validDirectives.has(directive);
+        // shrink-to-fit is not valid, but we have a separate warning for it.
+        return !validDirectives.has(directive) && directive != "shrink-to-fit";
     }).forEach((directive)=>{
         warnings.push(`Invalid viewport directive "${directive}".`);
     });
diff --git a/src/lib/validation.js b/src/lib/validation.js
@@ -675,6 +675,12 @@ function validateMetaViewport(element) {
     }
   }
 
+  if ("shrink-to-fit" in directives) {
+    warnings.push(
+      "The shrink-to-fit directive has been obsolete since iOS 9.2.\n  See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html"
+    );
+  }
+
   const validDirectives = new Set([
     "width",
     "height",
@@ -686,7 +692,8 @@ function validateMetaViewport(element) {
   ]);
   Object.keys(directives)
     .filter((directive) => {
-      return !validDirectives.has(directive);
+      // shrink-to-fit is not valid, but we have a separate warning for it.
+      return !validDirectives.has(directive) && directive != "shrink-to-fit";
     })
     .forEach((directive) => {
       warnings.push(`Invalid viewport directive "${directive}".`);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@rviscomi/capo.js",`
`3`		`- "version": "1.5.1",`
	`3`	`+ "version": "1.5.2",`
`4`	`4`	`"description": "Get your ﹤𝚑𝚎𝚊𝚍﹥ in order",`
`5`	`5`	`"author": "Rick Viscomi",`
`6`	`6`	`"license": "Apache-2.0",`